o-nikolas commented on code in PR #76408:
URL: https://github.com/apache/airflow/pull/76408#discussion_r4486560659
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/transfers/s3_to_wasb.py:
##########
@@ -193,6 +193,29 @@ def execute(self, context: Context) -> list[str]:
# Return a list of the files that were moved
return files_to_move
+ @staticmethod
+ def _strip_overlapping_folder_markers(keys: list[str]) -> tuple[list[str],
list[str]]:
Review Comment:
nit: this is now the third copy of this helper, after
`S3ToGCSOperator._strip_overlapping_folder_markers` and
`airflow.providers.amazon.aws.utils.transfer.strip_overlapping_folder_markers`.
I think copying makes sense here, since the `amazon` extra has no version
floor. Could you maybe add a one-line note that it mirrors the Amazon helper,
to help keep the copies in sync?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
