Re: [PR] UI: Add a Triggers page to browse every trigger of every kind [airflow]

[seanghaeli (via GitHub) via commits]

seanghaeli commented on PR #76567:
URL: https://github.com/apache/airflow/pull/76567#issuecomment-6675187511

   > Let's make sure we have a breadcrumb to make it easy to go back and forth 
from the triggers list and trigger details page
   
   In agreement. Analogous pages like the Dag and asset pages don't link back 
to their list in the breadcrumb, so I opted not to include one, but I have 
added one now.
   <img width="1600" height="900" alt="Breadcrumb on the trigger page" 
src="https://raw.githubusercontent.com/seanghaeli/airflow/1f1e70aeb488675af0aafeb6bd802749ea63c025/pr-76567/1_breadcrumb_circled.png";
 />
   
   > Nit. Update the dropdown to use the colored badges for the trigger states
   
   +1,
   <img width="1600" height="900" alt="Colored status badges in the status 
filter" 
src="https://raw.githubusercontent.com/seanghaeli/airflow/1f1e70aeb488675af0aafeb6bd802749ea63c025/pr-76567/2_status_dropdown_circled.png";
 />
   
   > Where can I see the actual dags affected?
   
   Adding it, here: 
   <img width="1600" height="900" alt="image" 
src="https://github.com/user-attachments/assets/94400da9-ab22-4faf-8e1b-64a1bf82a628";
 />
   
   > Does every trigger show up in some form on the dag dependency graph? I 
wonder if they should.
   
   For watchers, I like the idea of including them. I mocked it up here, let me 
know your thoughts:
   <img width="1600" height="900" alt="Asset watcher nodes upstream of their 
assets on the Dag graph" 
src="https://raw.githubusercontent.com/seanghaeli/airflow/1f1e70aeb488675af0aafeb6bd802749ea63c025/pr-76567/7_watcher_nodes_circled.png";
 />
   
   > I just did a lot to clean up the warnings and error badges on the Dag 
View. So we will have to think about that "1 watcher failing" status.
   
   For now I moved it to a small chip next to the Dag status chip ahead of the 
breadcrumb.
   <img width="1600" height="900" alt="Failing watcher chip ahead of the Dag 
breadcrumb" 
src="https://raw.githubusercontent.com/seanghaeli/airflow/1f1e70aeb488675af0aafeb6bd802749ea63c025/pr-76567/8_dag_chip_circled.png";
 />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org