shahar1 commented on code in PR #76348:
URL: https://github.com/apache/airflow/pull/76348#discussion_r4457033643
##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -700,8 +700,8 @@ def list(
Args:
state: Filter Dag runs by state (optional; no filter applied when
omitted)
- start_date: Filter Dag runs by start date (optional)
- end_date: Filter Dag runs by end date (optional)
+ start_date: Return only Dag runs that started at or after this
time (optional)
+ end_date: Return only Dag runs that ended at or before this time
(optional)
Review Comment:
nit (optional): "Return only" is a bit stronger than what the server does.
The `start_date` / `end_date` range filters also match rows where the column is
NULL (`NullableDatetimeRangeFilter` in
`airflow-core/src/airflow/api_fastapi/common/parameters/range.py`):
- `start_date_gte` also returns runs that have not started yet (no
`start_date` and no `end_date`).
- `end_date_lte` also returns runs that are still running when the given
time is later than now.
Mentioning that here would save a user a surprise, but it is fine to leave
as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
