RehanAhmad25 commented on PR #72499: URL: https://github.com/apache/airflow/pull/72499#issuecomment-6700321792
@ashb pushed, all six comments addressed, replies are in the threads. Thanks for the review. @fat-catTW @soupam05 heads up since we discussed the design earlier: following ashb's suggestion the masking now lives in a field serializer on DAGRunResponse, and routes attach the run's Dag (dag_run.dag = dag) instead of calling a factory. It still fails loudly if a Dag isn't attached, so the safety property is the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
