potiuk commented on PR #75908: URL: https://github.com/apache/airflow/pull/75908#issuecomment-6630084142
Thanks for the fix in 98ad3d3f81. I looked at the same failure and reached the same cause: `_emit_state_listener_hooks` passes task instances with no `task` set, so `_on_task_instance_manual_state_change` skips `get_airflow_run_facet`. That leaves one question. Events for manually changed task states never carry the `airflow` facet, and the tests now record that as expected. Is it intended, or worth a follow-up in the listener so these events carry the task instance state and try number too? It doesn't need to block this PR, but it would be good to know which it is. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
