nuclearpinguin commented on a change in pull request #7206: [AIRFLOW-6591] Add cli option to stop celery worker URL: https://github.com/apache/airflow/pull/7206#discussion_r369215821
########## File path: airflow/cli/commands/celery_command.py ########## @@ -23,8 +23,10 @@ from typing import Optional import daemon +import psutil from celery.bin import worker as worker_bin from daemon.pidfile import TimeoutPIDLockFile Review comment: Hm, and there's no pylint error? In my opinion we should use Celery builtin mechanism: https://docs.celeryproject.org/en/latest/reference/celery.bin.worker.html#cmdoption-celery-worker-pidfile the main advantage is that in this way it works for both worker's modes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
