meel-ayush commented on code in PR #76559:
URL: https://github.com/apache/airflow/pull/76559#discussion_r4502961239
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -1367,13 +1373,17 @@ def _refresh_dag_bundles(self, known_files: dict[str,
set[DagFileInfo]]):
# Keep the bundle's known files and Dags, and leave its
version unadvanced so the
# next refresh lists it again.
self.log.exception("Error listing Dag definitions in
bundle %s", bundle.name)
+ if self.api_client is None:
+ self._record_bundle_refresh_error(bundle.name,
traceback.format_exc())
Review Comment:
Good catch, thanks! Dropping it from _bundle_versions on listing failure
makes total sense so the unchanged-version short-circuit doesn't swallow the
error on subsequent loops. Applied and updated the test assertion accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
