Dev-iL commented on code in PR #75396:
URL: https://github.com/apache/airflow/pull/75396#discussion_r4503506618
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py:
##########
@@ -766,14 +787,16 @@ def set_xcom(
)
try:
# We expect serialised value from the caller - sdk, do not serialise
in here
- XComModel.set_for_attempt(
- key=key,
- value=value,
- task_instance_id=owner,
- serialize=False,
- dag_result=dag_result,
- mapped_length=mapped_length,
- session=session,
+ await session.run_sync(
Review Comment:
Thanks for running it against a non-UTC server. The time-zone half was fixed
on `main` in #76505, which this branch's base already includes. The isolation
level was still missing, and I fixed it separately in #76694 as you suggested.
There, the async engine gets the same `READ COMMITTED` setting as the sync one
through a shared helper. Its test reads `@@session.transaction_isolation`
through `settings.AsyncSession` for both `aiomysql` and `asyncmy`. That test
fails on `main` with `REPEATABLE-READ` and passes with the fix. This PR depends
on it for MySQL parity, so #76694 should merge first; the description says so.
---
Drafted-by: Claude Code (Opus 5.5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
