ramitkataria commented on code in PR #76311:
URL: https://github.com/apache/airflow/pull/76311#discussion_r4464923027
##########
task-sdk/src/airflow/sdk/execution_time/schema/versions/v2026_10_30.py:
##########
@@ -148,3 +149,13 @@ class
AddExecutionTimeoutToSupervisorTIRunContext(VersionChange):
instructions_to_migrate_to_previous_version = (
schema(TIRunContext).field("execution_timeout").didnt_exist,
)
+
+
+class AddTimeoutToTriggerDagRun(VersionChange):
Review Comment:
I think this would probably have to be moved to the `2027-02-28` version
instead?
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py:
##########
@@ -170,6 +170,11 @@ class DAGRunResponse(BaseModel):
start_date: datetime | None
end_date: datetime | None
duration: float | None
+ dag_run_timeout: timedelta | None = Field(
Review Comment:
On a run, `dag_run_timeout: null` means "inherits the Dag's timeout", while
`dag_run_timeout` on the Dag details response is the actual limit. A client
reading `null` on a run might assume there's no limit. Would it work to nest
this as `overrides.dag_run_timeout`, as suggested on the dev list thread? That
makes it clear it's the override, and it gives AIP-117 one place to add its
keys later. Since renaming a public API field after release is breaking, let's
settle on this before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
