shahar1 commented on issue #76568: URL: https://github.com/apache/airflow/issues/76568#issuecomment-6711748023
> > I'm a bit concerned about [#76131](https://github.com/apache/airflow/pull/76131). This removes `from airflow.sensors.time_delta import TimeDeltaSensorAsync`, and dropping backcompat shims from core is something we'd consider a breaking change (at least currently). Given the tighter coupling of standard and core than your typical provider, it just feels like we aren't following the spirit of core semver. > > I'm okay if the answer is "Jed, it's fine" but wanted to raise it 🤷 > > Yeah, that's a fair callout [@jedcunningham](https://github.com/jedcunningham)! This thing has been deprecated for well over a year and the fix if users are still using it is a one-liner, but I do think you're right about it being unexpected and not really respecting our semver as it relates to core here. So that would mean excluding that provider from this wave and then reverting [#76131](https://github.com/apache/airflow/pull/76131) on main and releasing again next wave as a minor instead of a major. Thoughts [@shahar1](https://github.com/shahar1) as the original author? 0. My bad, I missed it out while working on the PR and reviewing the changelogs. 1. I'd suggest, and vote, to exclude standard from this release 2. Revert #76131, while clarifying the warning and adding a static check to prevent for next time: https://github.com/apache/airflow/pull/76692 Good call Jed! (it's fine 😉) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
