uranusjr commented on code in PR #75184:
URL: https://github.com/apache/airflow/pull/75184#discussion_r4439645622
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -228,6 +228,17 @@ def __hash__(self):
r"^scripts/ci/lang_sdk_serialization/.*",
)
+# Sources of the `lang_sdk_xcom_object_storage` e2e mode, which runs the
configured XCom backend for
+# TypeScript, Go and Java task XComs: the coordinator-side backend, the base
XCom class it calls, the
+# object storage backend, and the mode's own compose override and tests.
+LANG_SDK_XCOM_BACKEND_FILES = (
+ r"^task-sdk/src/airflow/sdk/coordinators/_xcom_backend\.py$",
+ r"^task-sdk/src/airflow/sdk/bases/xcom\.py$",
+ r"^providers/common/io/src/airflow/providers/common/io/xcom/.*",
+ r"^airflow-e2e-tests/docker/lang-sdk-xcom-object-storage\.yml$",
+
r"^airflow-e2e-tests/tests/airflow_e2e_tests/lang_sdk_xcom_object_storage_tests/.*",
+)
Review Comment:
These are added to all three SDK e2e groups, so a change to `bases/xcom.py`
runs the Go, TS and Java e2e jobs as well as the new one. Can they trigger only
the `lang_sdk_xcom_object_storage` mode? The same goes for the `if:` on the new
job in `additional-prod-image-tests.yml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
