dabla commented on PR #76545: URL: https://github.com/apache/airflow/pull/76545#issuecomment-6737582192
@amoghrajesh @kaxil could one of you take a look at this from the threading side? Jens approved but asked for a second reviewer with more Python threading experience before it is merged. The change is limited to `CommsDecoder` in `comms.py` (plus its tests). A sync `send()` now waits for the channel while an `asend()` holds it, instead of interleaving frames on the socket. The benchmarks in the description show no slowdown on `send` and a faster `asend`. The parts worth a careful read are the reentrant lock around the exchange and the per-loop queues. #62922 depends on this, so a review would unblock that one too. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
