amoghrajesh commented on code in PR #76575:
URL: https://github.com/apache/airflow/pull/76575#discussion_r4509686423
##########
dev/breeze/src/airflow_breeze/commands/registry_commands.py:
##########
@@ -145,7 +145,28 @@ def extract_data(python: str, provider: str | None,
allow_unreleased: bool):
bring_compose_project_down(preserve_volumes=False,
shell_params=shell_params)
remove_docker_networks([f"{unique_project_name}_default"])
fix_ownership_using_docker()
- sys.exit(result.returncode)
+ if result.returncode:
+ sys.exit(result.returncode)
+
+ # Dating a durable module needs the providers-* tags, so it runs here
rather than beside
+ # the module extraction in the container.
+ with ci_group("Dating durable modules"):
+ versions_result = run_command(
+ [
+ "uv",
+ "run",
+ "--project",
+ str(DEV_REGISTRY_DIR),
+ "python",
+ str(DEV_REGISTRY_DIR / "fill_durable_versions.py"),
+ "--modules",
+ str(DEV_REGISTRY_DIR / "output" / "modules.json"),
Review Comment:
Pointed at `dev/registry/modules.json`. Fixed the same stale path in the
script's usage docstring.
Kept `registry/src/_data/modules.json` as the second argument. `breeze
registry extract-data` has no copy step, so a local preview reads that file
directly. In CI the Copy step runs after and overwrites it anyway.
##########
dev/registry/tests/test_fill_durable_versions.py:
##########
@@ -0,0 +1,204 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Unit tests for dev/registry/fill_durable_versions.py."""
Review Comment:
Thx, removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
