stephen-bracken commented on code in PR #76702:
URL: https://github.com/apache/airflow/pull/76702#discussion_r4514018097
##########
providers/keycloak/tests/unit/keycloak/auth_manager/cli/test_commands.py:
##########
@@ -778,12 +807,22 @@ def test_create_team_command(
decision_strategy="AFFIRMATIVE",
_dry_run=False,
)
+ mock_attach_policy.assert_any_call(
+ client,
+ "test-id",
+ permission_name="AdminViewAccess",
+ policy_name="Allow-GlobalReadOnly",
+ scope_names=["GET"],
+ resource_names=["AdminView"],
+ decision_strategy="AFFIRMATIVE",
+ _dry_run=False,
+ )
admin_view_policies = [
c.kwargs["policy_name"]
for c in mock_attach_policy.call_args_list
if c.kwargs["permission_name"] == "AdminViewAccess" or "AdminView"
in c.kwargs["resource_names"]
]
- assert admin_view_policies == ["Allow-SuperAdmin"]
+ assert admin_view_policies == ["Allow-SuperAdmin",
"Allow-GlobalReadOnly"]
Review Comment:
Fixed `_update_read_only_permission_resources` removing the team scoped
resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
