pierrejeambrun commented on code in PR #76747:
URL: https://github.com/apache/airflow/pull/76747#discussion_r4515133867
##########
providers/common/ai/src/airflow/providers/common/ai/plugins/www/src/model-api.ts:
##########
@@ -79,20 +88,19 @@ export function createModelApi(
region?: TaskRegion,
) {
return {
- fetchModelName: () =>
- fetchXComValue<string>(dagId, runId, taskId, mapIndex,
MODEL_NAME_XCOM_KEY, region),
- fetchUsage: async () => {
+ fetchModelName: async (): Promise<string | OffloadedValue | null> => {
+ const value = await fetchXComValue<string>(dagId, runId, taskId,
mapIndex, MODEL_NAME_XCOM_KEY, region);
+ // A reference is a string too, but a model name never holds a URI
scheme.
Review Comment:
On model-api.ts:93: Good point, thanks. Tying the check to a backend's path
layout felt too fragile, so I kept the :// check and accepted the vLLM case as
a known false positive: the comment no longer says "never", and the
observability docs mention it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
