sdaberdaku commented on code in PR #76749:
URL: https://github.com/apache/airflow/pull/76749#discussion_r4518885361


##########
chart/values.schema.json:
##########
@@ -1747,6 +1747,14 @@
                                     "items": {
                                         "type": "string"
                                     }
+                                },
+                                "terminationGracePeriodSeconds": {
+                                    "description": "Grace period, in seconds, 
for a kill triggered by this probe. Overrides the pod's 
`terminationGracePeriodSeconds` for liveness kills only.",

Review Comment:
   When a Kubernetes liveness probe fails, the kubelet triggers a container 
restart by first sending a SIGTERM signal to the main process.  By default, 
Kubernetes waits for the pod-level terminationGracePeriodSeconds for the 
process to exit gracefully; and it will send SIGKILL only after the grace 
period ends.
   
   If one sets a long termination grace period to avoid interrupting long 
running tasks on worker rollouts, they might still want the worker to be 
quickly restarted if it becomes unhealthy instead of waiting for the whole pod 
level grace period to run out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to