Lee-W commented on code in PR #75369: URL: https://github.com/apache/airflow/pull/75369#discussion_r4519800000
########## providers/common/ai/tests/unit/common/ai/hooks/test_pydantic_ai.py: ########## @@ -62,6 +64,9 @@ _GOOGLE_MODEL_PREFIX_RE = re.compile(r"google[\w-]*(?=:)") +def build_backend(*, model_name: str, base_url: str | None) -> ModelReadinessBackend: ... Review Comment: The stub now raises `NotImplementedError`. I kept a stub instead of autospeccing the protocol: `create_autospec(ModelReadinessBackendFactory, instance=True)` fails `assert_called_once_with(model_name=..., base_url=...)` even when the arguments match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
