o-nikolas commented on code in PR #76567:
URL: https://github.com/apache/airflow/pull/76567#discussion_r4530959680
##########
airflow-core/src/airflow/api_fastapi/core_api/services/ui/dependencies.py:
##########
@@ -212,6 +216,11 @@ def hide_unreadable_assets(
}
if not hidden:
return graph
+ hidden |= {
+ edge["source_id"]
+ for edge in graph["edges"]
+ if edge["target_id"] in hidden and
edge["source_id"].startswith("asset-watcher:")
+ }
Review Comment:
Can the new watcher branch in `hide_unreadable_assets` be reached? Both
`get_scheduling_dependencies` and `get_data_dependencies` call it before the
route adds any watcher nodes, and `add_asset_watcher_nodes` only adds watchers
to assets the caller can read anyway. Could we drop it, along with
`test_hide_unreadable_assets_drops_their_watchers`, which only exercises that
branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
