sidshas03 commented on issue #76875: URL: https://github.com/apache/airflow/issues/76875#issuecomment-6796174569
Button idea is good. One missed step and the proposal lands in the wrong list, and we come to know next day from Slack. Few things, since the #76845 check matches exact text: - Label and badge are different strings. Label is `airflow-improvement-proposal/<state>` (`wip/draft/accepted/completed/abandoned`), badge is `WIP/Under discussion/Accepted/Completed/Abandoned`. Base label `airflow-improvement-proposal` or `adip` must stay on the page, don't drop it while swapping the state label. - Folded header is matched character for character, e.g. `1 completed AIPs (click to expand)`. It keeps the "s" even for count 1. Only Completed and Abandoned are folded, so update counts only when moving in/out of those. - Count sits on the index page, so the person needs edit rights on the index too, not just the proposal. - Confluence writes need the current version number. Two people moving pages together will clash, so re-read the index and retry, else the move succeeds but count stays stale. - These are separate REST calls, can fail halfway. Show which step failed. AIP-52 (pageId 247827224) is edit-restricted, so expect a 403 there. On security: PMC-only page for the script is fine, but anyone who can edit an AIP can just drop their own html macro, so that alone won't stop misuse. Please confirm with ASF Infra that the macro stays and who can use it before putting it in templates. If they might disable it, a bookmarklet or a repo script using the committer's own login is safer. Avoid the scheduled job holding a wiki token in GitHub secrets. Would like to pick this up if that's okay. Mind assigning it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
