amoghrajesh commented on code in PR #76295: URL: https://github.com/apache/airflow/pull/76295#discussion_r4546218094
########## providers/databricks/docs/operators/notebook.rst: ########## @@ -80,3 +82,57 @@ attempt is observed, so downstream failure handling is not delayed by long-runni Only unlimited retries (``max_retries=-1``) keep the Airflow task waiting (or deferring) until the parent workflow run reaches a terminal state, because Databricks may still launch a retry attempt under the same ``task_key`` until then. Sibling tasks in the run continue independently. + + +Durable execution +----------------- + +Outside a +:class:`~airflow.providers.databricks.operators.databricks_workflow.DatabricksWorkflowTaskGroup`, +this operator submits a run and then waits for it, on the worker or in the Triggerer when +``deferrable=True``. By default it runs in a *durable* mode: the Databricks run id is persisted to +:doc:`task state store <apache-airflow:core-concepts/task-state-store>` before the wait begins, so if +the worker crashes or is preempted and the task is retried, the operator reconnects to the run that +is already executing on Databricks instead of submitting a duplicate. + +On retry the operator checks the prior run's state: + +* if it is still running, the operator reconnects and continues polling +* if it already succeeded, the operator returns immediately without resubmitting +* if it failed terminally, the operator submits a fresh run + +Pass ``durable=False`` to always submit a fresh run on retry. + +Unlike :class:`~airflow.providers.databricks.operators.databricks.DatabricksSubmitRunOperator` and +:class:`~airflow.providers.databricks.operators.databricks.DatabricksRunNowOperator`, where +``durable`` has no effect in deferrable mode, durable execution here also covers +``deferrable=True``: the run id is stored before the task defers, so a try lost while the Triggerer +was waiting still reconnects on the next one. + +Durable execution requires Airflow 3.3 or newer, since it relies on the task state store. On +earlier Airflow versions the flag is a no-op and the operator always submits a fresh run on retry. +If the task state store is unavailable at runtime, the operator logs that crash recovery is +disabled and behaves the same way. + +Inside a ``DatabricksWorkflowTaskGroup`` nothing changes: the run is submitted by the workflow +launch task and this operator only monitors its own task within that shared run, so a retry already +reconnects rather than resubmitting. + +The stored run id is not deleted automatically; that only happens when someone runs +``airflow state-store clean``. If a task's ``retry_delay`` is longer than +``[state_store] default_retention_days`` (30 days by default) and cleanup runs in between, the run +id is gone by the next retry and the operator submits a fresh run instead of reconnecting. Avoid Review Comment: Handled in [kaxil review](https://github.com/apache/airflow/pull/76295/commits/db20dcae1f6eb55b451ef26a33f4861641d0793f) ########## providers/databricks/tests/unit/databricks/operators/test_databricks.py: ########## @@ -5267,3 +5269,293 @@ def test_monitor_waits_out_waiting_for_retry_state(self, mock_databricks_hook, m operator.monitor_databricks_job() assert mock_databricks_hook.return_value.get_run.call_count == 3 + + [email protected]( + not AIRFLOW_V_3_3_PLUS, reason="task_state_store (durable execution) requires Airflow 3.3+" +) +class TestDatabricksTaskBaseOperatorDurable: + @pytest.fixture(params=["notebook", "task"]) + def make_operator(self, request): + def _make(**kwargs): + if request.param == "notebook": + return DatabricksNotebookOperator( + task_id=TASK_ID, + notebook_path="/test", + source="WORKSPACE", + new_cluster=NEW_CLUSTER, + **kwargs, + ) + return DatabricksTaskOperator( + task_id=TASK_ID, + task_config={"notebook_task": NOTEBOOK_TASK}, + new_cluster=NEW_CLUSTER, + **kwargs, + ) + + return _make + + @staticmethod + def _task_store(stored_run_id=None): + task_store = MagicMock(spec_set=["get", "set"]) + task_store.get.return_value = stored_run_id + return task_store + + @mock.patch("airflow.providers.databricks.operators.databricks.DatabricksHook") + def test_persists_run_id_on_fresh_submit(self, db_mock_class, make_operator): Review Comment: Handled in [kaxil review](https://github.com/apache/airflow/pull/76295/commits/db20dcae1f6eb55b451ef26a33f4861641d0793f) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
