Lee-W commented on code in PR #75937:
URL: https://github.com/apache/airflow/pull/75937#discussion_r4547351249
##########
.github/workflows/ci-image-checks.yml:
##########
@@ -423,9 +418,11 @@ jobs:
run: df -H
- name: Create /mnt/airflow-site directory
run: sudo mkdir -p /mnt/airflow-site && sudo chown -R "${USER}"
/mnt/airflow-site
- - name: "Clone airflow-site"
+ # The publish, back-reference and validation steps below use only
docs-archive/ in this directory.
+ # The apache/airflow-site repository has no docs-archive/, so these
steps work in an empty directory.
Review Comment:
```suggestion
# breeze requires AIRFLOW_SITE_DIRECTORY to be an existing directory
# (`--airflow-site-directory` uses `click.Path(exists=True)`), and the
steps below only
# read and write docs-archive/ in it. The apache/airflow-site
repository has no
# docs-archive/, so an empty directory is enough.
# TODO: let breeze create the directory itself, then drop this step.
```
it's ok from the CI perspective for now but ideally we should chnage breeze
instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
