nguyenb2306632-cmyk commented on issue #46293: URL: https://github.com/apache/airflow/issues/46293#issuecomment-6817591085
Hi! I'd like to work on this, but I want to confirm the direction first so I don't build something that can't be merged. I looked at current `main`, and the example in the description no longer works for a different reason than templating: `pod_generator.py` now rejects the legacy `KubernetesExecutor` key inside `executor_config` and raises a `TypeError` (https://github.com/apache/airflow/blob/c43ff0f/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/pod_generator.py#L189-L205). This matches what @kunaljubce found in June. Also, the title says `config_path` while the body says `config_file`. I couldn't find any open PR or linked work for this issue. Could a maintainer say which of these they would accept? 1. Close the issue as no longer applicable, because the legacy `executor_config["KubernetesExecutor"]` format was removed. 2. A docs-only change describing the supported way to run tasks against different clusters or configurations (for example with the hybrid executors from AIP-61). 3. A new supported per-task way to set the kube config file. If so, which parameter and which place would you prefer, and should it be templated? If (2) or (3) is acceptable, I'll start on it right away. In both cases I'll keep the PR small and focused, include tests, run the static checks locally, and say in the description that I used Gen-AI tooling, as the contributing guide asks. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
