bbovenzi commented on code in PR #76806:
URL: https://github.com/apache/airflow/pull/76806#discussion_r4552716974


##########
airflow-core/src/airflow/ui/src/components/Clear/useKeepTaskState.ts:
##########


Review Comment:
   We don't need this hook. I think it obfuscates the state chain: 
useLocalStorage → useClearKeepTaskStateDefault → useKeepTaskState → 
KeepTaskStateCheckbox
   
   Let's consolidate.
   
   If our modal has `lazyMount unmountOnExit` then we don't need the state 
reset.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to