yuseok89 commented on code in PR #75980:
URL: https://github.com/apache/airflow/pull/75980#discussion_r4558083639
##########
task-sdk/src/airflow/sdk/definitions/asset/__init__.py:
##########
@@ -178,7 +178,6 @@ def _sanitize_uri(inp: str | ObjectStoragePath) -> str:
netloc=normalized_netloc,
path=parsed.path.rstrip("/") or "/", # Remove all trailing slashes.
query=normalized_query,
- fragment="", # Ignore any fragments.
Review Comment:
Isn't this reverting an intended behavior? Fragments have been dropped here
on purpose since #37005, and on main `Asset("s3://bucket/key#part1").uri` is
`s3://bucket/key`. Changing it would likely also change the stored URI of
existing assets that have a fragment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
