bingqin2 commented on PR #76720:
URL: https://github.com/apache/airflow/pull/76720#issuecomment-6890918331

   Thanks for the quick reply. I'm not a maintainer, so both calls are theirs 
in the end. My view:
   
   - **Scope:** keeping this PR to `var` and `conn` looks fine to me. The 
description already says "related" and not "closes", and the results in my 
table stand on their own. For the `prev_*_success` proxies I wouldn't open a 
new issue: #51861 covers them, and [this 
comment](https://github.com/apache/airflow/issues/51861#issuecomment-5233777375)
 there already lists the four names. A second PR that links #51861 would be 
enough.
   - **Guard:** I'd keep the dunder check. A list of names would have to follow 
what each debugger, `copy` and `pickle` look up. The only cost is attribute 
access to a key like `__x__`, which the default template environment already 
rejects on main, and `.get()` still works. One line about that in the 
description would let a maintainer decide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to