sameerpandey17 commented on PR #73766:
URL: https://github.com/apache/airflow/pull/73766#issuecomment-6891397526

   Hi @codechrl, I went through this to learn how the option is wired up, and I 
checked a few things myself.
   
   I searched the repo (case-insensitive, so the env var form too) for 
task_instance_heartbeat_sec and local_task_job_heartbeat_sec. The only hits are 
config.yml, the rename rules in the core and ctl config_command.py, and the 
export line in tasks.rst, so nothing else reads either option. [workers] 
min_heartbeat_interval is the one that is read, in supervisor.py. Removing both 
names without a deprecation step makes sense to me for that reason.
   
   Three questions:
   
   1. In tasks.rst the how-to now sets MIN_HEARTBEAT_INTERVAL=600. I saw that 
value is also used as a wait time in the supervisor loop and affects how long a 
worker tolerates an unreachable API server. Did you run the how-to after the 
change to confirm it still reproduces a heartbeat timeout cleanly?
   2. The description says config update --fix now removes both names. Is there 
a test for that? I only saw the lint tests.
   3. #74515 edits the same how-to section, so should the two PRs be sorted out 
together?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to