xchwan commented on code in PR #75945:
URL: https://github.com/apache/airflow/pull/75945#discussion_r4579180961
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -21,6 +21,23 @@
## Airflow Dag Processor Deployment
#################################
{{- if .Values.dagProcessor.enabled }}
+{{- $globals := deepCopy . -}}
+{{- $dagProcessorSets := .Values.dagProcessor.sets | default list -}}
+{{- $enableDefault := .Values.dagProcessor.enableDefault -}}
+{{- if kindIs "invalid" $enableDefault -}}
+ {{- $enableDefault = not .Values.dagProcessor.sets -}}
+{{- end -}}
+{{- if $enableDefault -}}
+ {{- $dagProcessorSets = concat (list (dict "name" "default"))
$dagProcessorSets -}}
+{{- end -}}
+{{- range $dagProcessorSet := $dagProcessorSets -}}
Review Comment:
Agreed. I will add a render-time `fail` for duplicate set names, a set named
`default`, and names that are not DNS-1123 labels, with a test for each.
---
Drafted-by: Claude Code (Sonnet 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]