kaxil commented on a change in pull request #7249: [AIRFLOW-6626] Add email on
failure or retry to default config
URL: https://github.com/apache/airflow/pull/7249#discussion_r370552599
##########
File path: airflow/models/baseoperator.py
##########
@@ -299,8 +299,8 @@ def __init__(
task_id: str,
owner: str = conf.get('operators', 'DEFAULT_OWNER'),
email: Optional[Union[str, Iterable[str]]] = None,
- email_on_retry: bool = True,
- email_on_failure: bool = True,
+ email_on_retry: bool = conf.getboolean('email',
'default_email_on_retry'),
Review comment:
Don't get me wrong, I definitely don't have a serious concern over this.
Just want to think it through.
So currently we can set this flag on task level, in default_args so that it
applies to all tasks, dag level and with this change config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
