sjyangkevin opened a new pull request, #77138:
URL: https://github.com/apache/airflow/pull/77138
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
### What
Extend API JWT validation in the FAB auth manager with a password
fingerprint check.
### How
- Each JWT carries a `password_fingerprint` claim, derived from the user's
stored password hash and `[api] secret_key`.
- During validation, the claim is compared with the user's current
fingerprint. The check reuses the existing `[fab] cache_ttl` user cache.
- Users without a local password, such as OAuth or LDAP users, are not
affected.
Upgrade note: JWTs issued by earlier versions do not have the new claim, so
users need to log in again and API clients need to request a new token once
after upgrading.
### Testing
- Added tests for JWT validation after a password change through the user
API and after a password reset.
- Added tests for JWTs without the new claim, for a recently cached user,
and for the new claim itself.
- Updated existing `deserialize_user` tests to build their JWTs with
`serialize_user`.
I ran the FAB `auth_manager` and `www` unit tests and mypy on the changed
files, and tested it end to end with `breeze start-airflow`.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Generated-by: [Claude Code (Opus 5.5)] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
- I used it to better understand the current implementation, and plan for
end-to-end testing before and after the changes made in this PR.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]