Anurag-S1ngh commented on code in PR #77087:
URL: https://github.com/apache/airflow/pull/77087#discussion_r4581829461
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -1249,7 +1279,17 @@ def update_triggers(self, requested_trigger_ids:
set[int]):
)
if new_trigger_ids:
- workloads_to_create = self.build_trigger_workloads(new_trigger_ids)
+ now = time.monotonic()
+ ready_ids = {tid for tid in new_trigger_ids if
self.failure_tracker.attempt_ready(tid, now)}
Review Comment:
Good catch. Applied in 272980f: the recorded count is now loaded in
`build_trigger_workloads` before the workload is built, and the trigger is
skipped until its backoff passes. The existing test that asserted immediate
re-creation was checking a mocked build, so it could not catch this. It now
runs the real build path and covers the delay.
---
Drafted-by: OpenCode (DeepSeek V4.1 Flash); reviewed by @Anurag-S1ngh before
posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]