Pablo-aps commented on PR #76828: URL: https://github.com/apache/airflow/pull/76828#issuecomment-6914909773
I ran the validator from `4679151` with SQLGlot 30.0.0. In `test_partition_guard_join_on_clause_partition_filter`, removing just `WHERE dim.active = true` makes the query fail with `lacks a WHERE clause or partition filter`. The `LEFT JOIN` still restricts `large_fact.dt` to the same date, and `large_fact` is the only table in `partition_columns`. `check_query_partition_filters` raises on the missing `WHERE` before it considers `join_on_nodes`. Could you cover that variant in the test? For a `LEFT JOIN`, an `ON` predicate can bound the right-hand input. The same predicate on the preserved left-hand input doesn’t filter its rows, so the side of the join matters here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
