jason810496 commented on code in PR #76807: URL: https://github.com/apache/airflow/pull/76807#discussion_r4585292976
########## go-sdk/DEVELOPMENT.md: ########## @@ -245,9 +245,36 @@ Pre-send checklist: * `go list -m github.com/apache/airflow/go-sdk@v<VERSION>-rc<N>` resolves. * `Changes since <the last release>` and the vote deadline are filled in. +* The RC commit passes the + [commit check](../dev/README_RELEASE_LANGUAGE_SDKS.md#check-the-release-candidate-commit). * Run `grep '<' email.txt` on the rendered email and confirm **no output** — any match means a template placeholder was left unfilled. +### After a successful vote + +Follow [After a successful vote](../dev/README_RELEASE_LANGUAGE_SDKS.md#after-a-successful-vote) +in the shared release doc. Go has no binaries to publish. Its "Publish the +binaries" step is: + +1. **Warm** the module proxy, so the release is fetchable right away and the + proxy records the tag's commit: + + ```bash + GOPROXY=https://proxy.golang.org go list -m github.com/apache/airflow/go-sdk@v<VERSION> + ``` + + It should print `github.com/apache/airflow/go-sdk v<VERSION>`. + +2. **Request** the API docs on pkg.go.dev. Open + `https://pkg.go.dev/github.com/apache/airflow/go-sdk@v<VERSION>` and, if the + version isn't shown yet, click *Request*. Indexing can take a few minutes. Review Comment: Could we add a warning here saying DON'T access the link until we add the git tag? Otherwise the package will be unreachable for a hour or so, thanks. ########## go-sdk/DEVELOPMENT.md: ########## @@ -245,9 +245,36 @@ Pre-send checklist: * `go list -m github.com/apache/airflow/go-sdk@v<VERSION>-rc<N>` resolves. * `Changes since <the last release>` and the vote deadline are filled in. +* The RC commit passes the + [commit check](../dev/README_RELEASE_LANGUAGE_SDKS.md#check-the-release-candidate-commit). * Run `grep '<' email.txt` on the rendered email and confirm **no output** — any match means a template placeholder was left unfilled. +### After a successful vote + +Follow [After a successful vote](../dev/README_RELEASE_LANGUAGE_SDKS.md#after-a-successful-vote) +in the shared release doc. Go has no binaries to publish. Its "Publish the +binaries" step is: + +1. **Warm** the module proxy, so the release is fetchable right away and the + proxy records the tag's commit: + + ```bash + GOPROXY=https://proxy.golang.org go list -m github.com/apache/airflow/go-sdk@v<VERSION> + ``` + + It should print `github.com/apache/airflow/go-sdk v<VERSION>`. + +2. **Request** the API docs on pkg.go.dev. Open + `https://pkg.go.dev/github.com/apache/airflow/go-sdk@v<VERSION>` and, if the + version isn't shown yet, click *Request*. Indexing can take a few minutes. Review Comment: Could we add a warning here saying DON'T access the link until we push the git tag? Otherwise the package will be unreachable for a hour or so, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
