arifrhm commented on code in PR #77046:
URL: https://github.com/apache/airflow/pull/77046#discussion_r4591764668


##########
providers/common/messaging/src/airflow/providers/common/messaging/triggers/msg_queue.py:
##########
@@ -68,20 +70,55 @@ class MessageQueueTrigger(BaseEventTrigger):
     def __init__(
         self,
         *,
-        queue: str | None = None,
         scheme: str | None = None,
+        queue: str | None = None,
         trigger_queue: str | None = None,
+        queue_uri: str | None = None,

Review Comment:
   Good catch! Removed `queue_uri` from `__init__` and docstrings. Callers 
using legacy URI matching continue passing `queue=<uri>`, while new callers use 
`scheme` and `queue` for trigger routing.



##########
providers/common/messaging/src/airflow/providers/common/messaging/triggers/msg_queue.py:
##########
@@ -68,20 +70,55 @@ class MessageQueueTrigger(BaseEventTrigger):
     def __init__(
         self,
         *,
-        queue: str | None = None,
         scheme: str | None = None,
+        queue: str | None = None,
         trigger_queue: str | None = None,
+        queue_uri: str | None = None,
         **kwargs: Any,
     ) -> None:
-        # Stored under our own name rather than through 
`BaseEventTrigger.__init__(queue=...)` so this
-        # works regardless of the installed airflow-core version, see `queue` 
property below.
-        self._trigger_queue = trigger_queue
+        if trigger_queue is not None:
+            warnings.warn(
+                "The `trigger_queue` parameter is deprecated and will be 
removed in a future version. "
+                "Use `queue` instead to assign this trigger to a trigger 
queue.",
+                AirflowProviderDeprecationWarning,
+                stacklevel=2,
+            )
 
-        if queue is None and scheme is None:
-            raise ValueError("Either `queue` or `scheme` parameter must be 
provided.")
+        if queue_uri is not None:
+            warnings.warn(
+                "The `queue_uri` parameter is deprecated and will be removed 
in future versions. "
+                "Use the `scheme` parameter instead and pass configuration as 
keyword arguments to `MessageQueueTrigger`.",
+                AirflowProviderDeprecationWarning,
+                stacklevel=2,
+            )
 
-        # For backward compatibility, queue takes precedence
-        if queue is not None:
+        # Determine whether `queue` represents the trigger queue or the legacy 
broker queue URI.
+        # When `scheme` or `queue_uri` is explicitly provided, `queue` is the 
trigger queue.
+        # When neither is provided, `queue` is treated as the legacy broker 
queue URI for backward compatibility.
+        if scheme is not None and queue_uri is None and queue is not None and 
"://" in queue:

Review Comment:
   Updated! Normalized at the top of `__init__` using 
`any(provider.queue_matches(queue) for provider in MESSAGE_QUEUE_PROVIDERS)`. 
If `queue` is a broker queue URI, it normalizes into `self.queue_uri` and sets 
`queue = None`. After that point `queue` strictly represents the trigger queue, 
eliminating the `elif queue is not None` branch and properly supporting 
third-party providers with arbitrary patterns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to