fat-catTW commented on code in PR #76748:
URL: https://github.com/apache/airflow/pull/76748#discussion_r4599006884


##########
providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py:
##########
@@ -345,6 +345,33 @@ def _fetch_user() -> User:
                     self.session.remove()
                 raise
 
+    async def deserialize_user_async(self, token: dict[str, Any]) -> User:

Review Comment:
   Checked the existing convention.
   When sync and async variants coexist, Airflow uses the `_async` suffix (e.g. 
`create_session_async`, `paginated_select_async`). I kept 
`deserialize_user_async` since `deserialize_user` remains the synchronous 
compatibility hook.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to