This is an automated email from the ASF dual-hosted git repository.
bbovenzi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 0b73e17633c Scope Dags list import errors badge to the selected bundle
(#77186)
0b73e17633c is described below
commit 0b73e17633cc470e6d93da05dbdb7a06d86e85d3
Author: Yeonguk Choo <[email protected]>
AuthorDate: Wed Nov 18 06:49:46 2026 +0900
Scope Dags list import errors badge to the selected bundle (#77186)
---
.../src/airflow/ui/src/pages/DagsList/DagsList.tsx | 2 +-
.../ui/src/pages/Dashboard/Stats/DagImportErrors.tsx | 11 ++++++++---
.../Dashboard/Stats/DagImportErrorsModal.test.tsx | 18 ++++++++++++++++++
.../src/pages/Dashboard/Stats/DagImportErrorsModal.tsx | 4 +++-
4 files changed, 30 insertions(+), 5 deletions(-)
diff --git a/airflow-core/src/airflow/ui/src/pages/DagsList/DagsList.tsx
b/airflow-core/src/airflow/ui/src/pages/DagsList/DagsList.tsx
index a1dcdce4d1c..9a183cea5ae 100644
--- a/airflow-core/src/airflow/ui/src/pages/DagsList/DagsList.tsx
+++ b/airflow-core/src/airflow/ui/src/pages/DagsList/DagsList.tsx
@@ -402,7 +402,7 @@ export const DagsList = () => {
</HStack>
</VStack>
}
- headingExtra={<DagImportErrors iconOnly />}
+ headingExtra={<DagImportErrors bundleName={selectedBundle}
iconOnly />}
initialState={tableURLState}
isLoading={isLoading}
modelName="common:dag"
diff --git
a/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrors.tsx
b/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrors.tsx
index 5a326b114fe..3ecfc9c2689 100644
--- a/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrors.tsx
+++ b/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrors.tsx
@@ -29,13 +29,18 @@ import { formatNumber } from "src/utils";
import { DagImportErrorsModal } from "./DagImportErrorsModal";
-export const DagImportErrors = ({ iconOnly = false }: { readonly iconOnly?:
boolean }) => {
+type DagImportErrorsProps = {
+ readonly bundleName?: string;
+ readonly iconOnly?: boolean;
+};
+
+export const DagImportErrors = ({ bundleName, iconOnly = false }:
DagImportErrorsProps) => {
const { onClose, onOpen, open } = useDisclosure();
const { i18n, t: translate } = useTranslation("dashboard");
const isRTL = i18n.dir() === "rtl";
- const { data, isLoading } = useImportErrorServiceGetImportErrors({ limit: 1
});
+ const { data, isLoading } = useImportErrorServiceGetImportErrors({
bundleName, limit: 1 });
const importErrorsCount = data?.total_entries ?? 0;
if (isLoading) {
@@ -71,7 +76,7 @@ export const DagImportErrors = ({ iconOnly = false }: {
readonly iconOnly?: bool
onClick={onOpen}
/>
)}
- <DagImportErrorsModal onClose={onClose} open={open} />
+ <DagImportErrorsModal bundleName={bundleName} onClose={onClose}
open={open} />
</Box>
);
};
diff --git
a/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.test.tsx
b/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.test.tsx
index d38258d9ca0..86c27e375c3 100644
---
a/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.test.tsx
+++
b/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.test.tsx
@@ -56,4 +56,22 @@ describe("DagImportErrorsModal", () => {
await waitFor(() =>
expect(writeText).toHaveBeenCalledWith(importError.stack_trace));
});
+
+ it.each([
+ ["my-bundle", "my-bundle"],
+ [undefined, null],
+ ])("requests import errors scoped to bundle %s", async (bundleName,
expectedParam) => {
+ const requestedBundles: Array<string | null> = [];
+
+ server.use(
+ http.get("/api/v2/importErrors", ({ request }) => {
+ requestedBundles.push(new
URL(request.url).searchParams.get("bundle_name"));
+
+ return HttpResponse.json({ import_errors: [], total_entries: 0 });
+ }),
+ );
+ render(<DagImportErrorsModal bundleName={bundleName} onClose={vi.fn()}
open />, { wrapper: Wrapper });
+
+ await waitFor(() => expect(requestedBundles).toEqual([expectedParam]));
+ });
});
diff --git
a/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.tsx
b/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.tsx
index e3fe84aa36e..451cac21296 100644
---
a/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.tsx
+++
b/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.tsx
@@ -43,6 +43,7 @@ import { useHasMultipleDagBundles } from
"src/queries/useHasMultipleDagBundles";
import { createErrorToaster } from "src/utils";
type ImportDAGErrorModalProps = {
+ readonly bundleName?: string;
readonly onClose: () => void;
readonly open: boolean;
};
@@ -85,7 +86,7 @@ const ReparseButton = ({
);
};
-export const DagImportErrorsModal = ({ onClose, open }:
ImportDAGErrorModalProps) => {
+export const DagImportErrorsModal = ({ bundleName, onClose, open }:
ImportDAGErrorModalProps) => {
const [page, setPage] = useState(1);
const [searchQuery, setSearchQuery] = useState("");
const [pollAfterReparse, setPollAfterReparse] = useState(false);
@@ -94,6 +95,7 @@ export const DagImportErrorsModal = ({ onClose, open }:
ImportDAGErrorModalProps
const { data } = useImportErrorServiceGetImportErrors(
{
+ bundleName,
filenamePattern: searchQuery || undefined,
limit: PAGE_LIMIT,
offset: PAGE_LIMIT * (page - 1),