This is an automated email from the ASF dual-hosted git repository.

choo121600 pushed a commit to branch v3-4-test
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/v3-4-test by this push:
     new 947987e4cf4 Add tooltips to copy buttons in import error views 
(#77165) (#77214)
947987e4cf4 is described below

commit 947987e4cf48debb0dca78433fde75858c2b7f2c
Author: Brent Bovenzi <[email protected]>
AuthorDate: Tue Nov 17 23:32:14 2026 -0500

    Add tooltips to copy buttons in import error views (#77165) (#77214)
    
    (cherry picked from commit 740539cd36d946ea7a5e1ce5654fea421e688038)
    
    Co-authored-by: Yeonguk Choo <[email protected]>
---
 .../ui/public/i18n/locales/en/dashboard.json       |  1 +
 .../ui/src/components/DagImportErrorDetails.tsx    |  2 +-
 .../pages/Dashboard/Stats/DagImportErrorsModal.tsx |  2 +-
 .../airflow/ui/src/system-components/Clipboard.tsx | 28 +++++++++++++++-------
 4 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/airflow-core/src/airflow/ui/public/i18n/locales/en/dashboard.json 
b/airflow-core/src/airflow/ui/public/i18n/locales/en/dashboard.json
index 8cf3b42bb95..002512f30ff 100644
--- a/airflow-core/src/airflow/ui/public/i18n/locales/en/dashboard.json
+++ b/airflow-core/src/airflow/ui/public/i18n/locales/en/dashboard.json
@@ -55,6 +55,7 @@
   "history": "History",
   "importErrors": {
     "bundle": "Bundle",
+    "copyStackTrace": "Copy stack trace",
     "dagImportError_one": "Dag Import Error",
     "dagImportError_other": "Dag Import Errors",
     "searchByFile": "Search by file",
diff --git 
a/airflow-core/src/airflow/ui/src/components/DagImportErrorDetails.tsx 
b/airflow-core/src/airflow/ui/src/components/DagImportErrorDetails.tsx
index 1bed66d728a..1bc1d364dab 100644
--- a/airflow-core/src/airflow/ui/src/components/DagImportErrorDetails.tsx
+++ b/airflow-core/src/airflow/ui/src/components/DagImportErrorDetails.tsx
@@ -52,7 +52,7 @@ export const DagImportErrorDetails = ({ importError }: { 
readonly importError: I
         <PiFilePy />
         {importError.filename}
         <ClipboardRoot value={importError.stack_trace}>
-          <ClipboardIconButton variant="outline" />
+          <ClipboardIconButton 
label={translate("importErrors.copyStackTrace")} variant="outline" />
         </ClipboardRoot>
         <IconButton
           data-testid="reparse-import-error"
diff --git 
a/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.tsx
 
b/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.tsx
index 076d981dc3b..e3fe84aa36e 100644
--- 
a/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.tsx
+++ 
b/airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/DagImportErrorsModal.tsx
@@ -187,7 +187,7 @@ export const DagImportErrorsModal = ({ onClose, open }: 
ImportDAGErrorModalProps
                   onReparsed={() => setPollAfterReparse(true)}
                 />
                 <ClipboardRoot value={importError.stack_trace}>
-                  <ClipboardIconButton variant="outline" />
+                  <ClipboardIconButton 
label={translate("importErrors.copyStackTrace")} variant="outline" />
                 </ClipboardRoot>
               </Box>
             </HStack>
diff --git a/airflow-core/src/airflow/ui/src/system-components/Clipboard.tsx 
b/airflow-core/src/airflow/ui/src/system-components/Clipboard.tsx
index 58839a2956c..c70e0b7da11 100644
--- a/airflow-core/src/airflow/ui/src/system-components/Clipboard.tsx
+++ b/airflow-core/src/airflow/ui/src/system-components/Clipboard.tsx
@@ -79,14 +79,26 @@ export const ClipboardLink = forwardRef<HTMLButtonElement, 
ButtonProps>((props,
   </ChakraClipboard.Trigger>
 ));
 
-export const ClipboardIconButton = forwardRef<HTMLButtonElement, 
ButtonProps>((props, ref) => (
-  <ChakraClipboard.Trigger asChild>
-    <IconButton ref={ref} size="xs" variant="ghost" {...props}>
-      <ClipboardIcon />
-      <ClipboardCopyText srOnly />
-    </IconButton>
-  </ChakraClipboard.Trigger>
-));
+export const ClipboardIconButton = forwardRef<HTMLButtonElement, { readonly 
label?: string } & ButtonProps>(
+  ({ label, ...props }, ref) => {
+    const { t: translate } = useTranslation("components");
+
+    return (
+      <ChakraClipboard.Trigger asChild>
+        <IconButton
+          label={label ?? translate("clipboard.copy")}
+          ref={ref}
+          size="xs"
+          variant="ghost"
+          {...props}
+        >
+          <ClipboardIcon />
+          <ClipboardCopyText srOnly />
+        </IconButton>
+      </ChakraClipboard.Trigger>
+    );
+  },
+);
 
 export const ClipboardInput = forwardRef<HTMLInputElement, InputProps>((props, 
ref) => (
   <ChakraClipboard.Input asChild>

Reply via email to