ramitkataria commented on code in PR #76996:
URL: https://github.com/apache/airflow/pull/76996#discussion_r4610845847


##########
providers/amazon/tests/system/amazon/aws/example_sagemaker_endpoint.py:
##########
@@ -299,7 +299,7 @@ def set_up(env_id, role_arn, ti=None):
         delete_model,
         delete_bucket,
         log_cleanup,
-        
archive_logs(f"/aws/sagemaker/Endpoints/{test_setup['endpoint_name']}"),
+        
print_and_delete_log_group_task(f"/aws/sagemaker/Endpoints/{test_setup['endpoint_name']}"),

Review Comment:
   `delete_endpoint` returns while the endpoint is still `Deleting`, and this 
runs a few tasks later. If the container flushes anything after 
`delete_log_group`, SageMaker recreates the group with no retention and it 
stays forever. `archive_logs` was safe against that because the 1-day retention 
stuck to the group. Could we wait for the endpoint to be gone first (the 
`endpoint_deleted` waiter), the way the DMS test waits for the replication 
instance?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to