SachinyadavAug20 commented on code in PR #77209: URL: https://github.com/apache/airflow/pull/77209#discussion_r4615852702
########## providers/amazon/src/airflow/providers/amazon/aws/auth_manager/routes/login.py: ########## @@ -81,6 +82,10 @@ # invalidate the first. The cap bounds the cookie; the oldest pending login is dropped. MAX_PENDING_LOGINS = 5 +# Cap the length of the redirect URL stored in the pending entry so that 5 pending entries +# do not push the base64-encoded cookie past the ~4 KB browser limit. +MAX_NEXT_URL_LENGTH = 500 Review Comment: yup, on the \uXXXX expansion with unicode! Updated this to check `len(json.dumps(next_url)) <= 400` so it stays well under 4 KB even with non-Latin-1 characters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
