vincbeck opened a new pull request, #77246:
URL: https://github.com/apache/airflow/pull/77246

   psycopg 3 is the default synchronous PostgreSQL driver since #69469, but its 
errors carry the SQLSTATE in `sqlstate` instead of psycopg2's `pgcode`, and 
their first argument is the message. A real "lock not available" error (55P03) 
raised through psycopg 3 was therefore not recognised as one.
   
   PostgreSQL raises that error when the scheduler's NOWAIT lock on the pool 
rows meets a row lock held by another transaction, such as a pool update from 
the API or the CLI, and when the 30 second lock timeout the Dag processor uses 
to mark stale or deleted Dags expires. Both places are meant to skip the 
iteration; with psycopg 3 the error escaped and stopped the scheduler or the 
Dag processor. Contention between schedulers was not affected, because the 
advisory lock taken first raises an error of its own.
   
   Taking only the first code a driver exposes is not enough: 
mysql-connector-python sets a generic `sqlstate` next to the MySQL error code, 
which hid its deadlocks from the deadlock check.
   
   PostgreSQL users on the default driver can now get the backfill routes' 503 
for a lock error. Its text told every user that backfills are not supported on 
SQLite, so it now says what happened and gives that advice only when the error 
comes from SQLite.
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
https://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a 
short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to