fat-catTW commented on code in PR #71214:
URL: https://github.com/apache/airflow/pull/71214#discussion_r4624267701


##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -327,9 +327,9 @@ def callback_data_with_context():
         elif isinstance(self.callback, ExecutorCallback):
             data = callback_data_with_context()
             data["deadline_id"] = str(self.id)
-            data["dag_run_id"] = str(self.dagrun.id)
             data["dag_id"] = self.dagrun.dag_id
             self.callback.data = data
+            self.callback.dagrun_id = self.dagrun.id

Review Comment:
   Thanks for the review.  Addressed. 
   Callback cleanup now scopes through `callback.dagrun_id → dag_run.dag_id`, 
and `Deadline.__init__` sets the callback's `dagrun_id` when it is created.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to