RehanAhmad25 commented on code in PR #74539:
URL: https://github.com/apache/airflow/pull/74539#discussion_r4625494682
##########
providers/microsoft/mssql/tests/unit/microsoft/mssql/hooks/test_mssql.py:
##########
@@ -403,3 +403,157 @@ def test_get_extra(self, get_connection,
mssql_connections):
hook = MsSqlHook()
assert hook.get_connection().extra
+
+
+def _mssql_hook(extra: str = "{}") -> MsSqlHook:
Review Comment:
Done. The helper uses `MsSqlHook(connection=conn)` now (no Mock, no type:
ignore) and takes a port parameter. Added
`test_get_conn_mssql_python_without_port`, which pins the Server=localhost case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]