uranusjr commented on code in PR #77080:
URL: https://github.com/apache/airflow/pull/77080#discussion_r4625745195


##########
airflow-core/adr/yaml-dags/0001-task-mapping-authoring-interface.md:
##########
@@ -0,0 +1,211 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+
+# ADR-0001: Task Mapping — YAML Authoring Interface
+
+## Status
+
+Proposed.
+
+## Context
+
+What a mapped task is, and the rules every authoring surface follows, are in 
[Language SDK ADR-0016](../lang-sdk/0016-mapped-tasks-across-lang-sdks.md). 
This ADR records their spelling in YAML. `map` is deferred since it requires a 
way to reference a callable (see Decision 4 below).
+
+YAML has no method calls to chain. ADR-0016 makes `zip` and `concat` methods 
on a reference, so they chain in declaration order. YAML nests them instead. 
Since YAML already marks a value in place (`{$x: ...}` for an upstream output), 
an expanded argument is marked the same way:
+
+```yaml
+tasks:
+  # Returns e.g. [1, 2, 3]
+  - id: list_files
+    run: {}
+
+  # Equivalent to process.partial(bucket="raw").expand(path=list_files)
+  - id: process
+    run:
+      bucket: raw
+      path: {$expand: {$x: list_files}}
+
+  # Reducing; equivalent to summarize(sizes=process)
+  - id: summarize
+    run:
+      sizes: {$x: process}
+```
+
+## Decision
+
+1. **An expanded argument is marked in place with `$expand`. Every unmarked 
argument is a `partial()`.**
+   - For example, `path: {$expand: <source>}` under `with:` or `run:` is 
Python's `.expand(path=<source>)`.
+   - Several `$expand` arguments give a cross product, as several `expand()` 
keywords do. It is not allowed to nest `$expand` inside a construct.
+
+2. **Expansion is possible on a literal list, a `$x`, or one of `$zip` and 
`$concat`.**
+   - A list gives one instance per item. Its items are literal values; a 
marker inside it is an error. Any other literal is an error.

Review Comment:
   The problem is argument ordering, which is significant in Java and Go (they 
don’t have keyword arguments). If the `expand_kwargs` arguments aren’t defined 
with others, we won’t be able to support certain partial/expand combinations 
without having a very specific handler definition, which may be out of the YAML 
Dag author’s control. I added a sentence here to explain.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to