SachinyadavAug20 commented on PR #77282:
URL: https://github.com/apache/airflow/pull/77282#issuecomment-7014745369

   Hey @vincbeck, I've pushed an update addressing the review comments!
   
   - Removed the redundant test case in `test_aws_auth_manager.py`.
   - Updated the PR title to plain prose to satisfy Airflow's static checks.
   - Replied inline regarding the motivation (interface consistency with 
Keycloak, FAB, and Simple auth managers).
   
   Ready for another look whenever convenient. If you prefer to leave 
`get_url_login` minimal since core doesn't call it with `next_url` today, I'm 
also completely fine closing this out. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to