vincbeck commented on code in PR #76527:
URL: https://github.com/apache/airflow/pull/76527#discussion_r4632216249


##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -919,6 +1058,10 @@ def finalize_trigger_log(self, trigger_id: int) -> None:
         Every path that drops an id from ``running_triggers`` has to call it: 
re-creation
         reuses the log path, so a leftover entry is lost.
         """
+        # A watcher's file outlives its instances: update_triggers closes it 
once the trigger leaves,
+        # after the instance's last lines arrived on the log socket.
+        if isinstance(self.logger_cache.get(trigger_id), 
WatcherLoggingFactory):
+            return
         if factory := self.logger_cache.pop(trigger_id, None):

Review Comment:
   nit: `_trigger_log_errors_at` is only cleaned for watchers, so every task or 
callback trigger that hit a log error stays in it for the life of the 
triggerer. Pop it here too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to