ChickenBenny commented on code in PR #77311:
URL: https://github.com/apache/airflow/pull/77311#discussion_r4640720077
##########
providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py:
##########
@@ -645,32 +645,36 @@ def get_authorized_dag_ids(
# If user is authorized to access all DAGs, return all DAGs
return {dag.dag_id for dag in
session.execute(select(DagModel.dag_id))}
if isinstance(user, AnonymousUser):
Review Comment:
Fix with
[c842ce9](https://github.com/apache/airflow/pull/77311/commits/c842ce9baf20bd7739a28cac196483c7f4dbd914).
Switched to `_get_user_permissions(user)` for every `user. _is_authorized`
right above already reads the cached perms, so the two checks now agree, and
the DAGs check in the loop could never match anymore, so I dropped it too.
Updated the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]