ashb commented on a change in pull request #7267: [AIRFLOW-6645] Pass the
TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#discussion_r372617259
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -39,12 +38,20 @@ class FileTaskHandler(logging.Handler):
:param base_log_folder: Base log folder to place logs.
:param filename_template: template filename string
"""
- def __init__(self, base_log_folder: str, filename_template: str):
+ def __init__(
+ self,
+ base_log_folder: str,
+ filename_template: str,
+ worker_server_log_port: int,
Review comment:
The config option is called `worker_log_server_port` - did you give this a
slightly different name on purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
