larryzhu2018 commented on a change in pull request #7141: [AIRFLOW-6544] add 
log_id to end_of_log mark log record
URL: https://github.com/apache/airflow/pull/7141#discussion_r372652360
 
 

 ##########
 File path: tests/utils/log/test_es_task_handler.py
 ##########
 @@ -262,21 +277,55 @@ def 
test_set_context_w_json_format_and_write_stdout(self):
         self.es_task_handler.json_format = True
         self.es_task_handler.set_context(self.ti)
 
-    def test_close(self):
-        formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s 
- %(message)s')
 
 Review comment:
   @pingzh you do not use log_id at all in your deployment. you need that in 
order to make the airflow webui to work as the web ui is searching for the 
log_id, without that it will keep spinning. Can you please review the comments 
I added here and check? 
   
   please come back to me here, and tell us if you can make this work with the 
non-json log format. I do not think you can construct the log_id that is needed 
for the web-ui using the non-json log format.
   Let me recap: IIUC the only reason that you think your deployment worked was 
because you missed out the log_id logic completely and I have explained how it 
should work, where it is used, and also add added a unit test case to show you 
how this can work. Please reviews my explanations here and see if it is clear 
to you now. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to