ashb commented on a change in pull request #7133: [AIRFLOW-6535] add exception 
to fail without retry
URL: https://github.com/apache/airflow/pull/7133#discussion_r374840503
 
 

 ##########
 File path: airflow/models/taskinstance.py
 ##########
 @@ -1124,64 +1129,56 @@ def handle_failure(self, error, test_mode=None, 
context=None, session=None):
         if context is not None:
             context['exception'] = error
 
-        # Let's go deeper
-        try:
 
 Review comment:
   Does is_eligable_for_retry do anything more than check instance attributes? 
If not then this change is probably okay

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to