feluelle commented on a change in pull request #7410: [AIRFLOW-6790] Add basic Tableau Integration URL: https://github.com/apache/airflow/pull/7410#discussion_r379056816
########## File path: airflow/providers/salesforce/hooks/tableau.py ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from tableauserverclient import Pager, Server, TableauAuth + +from airflow.hooks.base_hook import BaseHook + + +class TableauHook(BaseHook): + """ + Connects to the Tableau Server Instance and allows to communicate with it. + + :param site_id: The id of the site where the workbook belongs to. + :type site_id: str + :param tableau_conn_id: The Tableau Connection id containing the credentials + to authenticate to the Tableau Server. + :type tableau_conn_id: str + """ + + def __init__(self, site_id='', tableau_conn_id='tableau_default'): Review comment: Actually I think I will remove the default ```suggestion def __init__(self, site_id='', tableau_conn_id'): ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
