ashb commented on a change in pull request #7413: [AIRFLOW-6793] Respect env
variable in airflow config command
URL: https://github.com/apache/airflow/pull/7413#discussion_r379337848
##########
File path: tests/cli/commands/test_config_command.py
##########
@@ -43,3 +43,10 @@ def test_cli_show_config_should_display_key(self):
config_command.show_config(self.parser.parse_args(['config']))
self.assertIn('[core]', temp_stdout.getvalue())
self.assertIn('testkey = test_value', temp_stdout.getvalue())
+
+ @mock.patch.dict("os.environ", {"AIRFLOW__CORE__DAGS_FOLDER":
"/tmp/test_folder"})
+ def test_cli_show_config_should_respect_env_variable(self):
+ with contextlib.redirect_stdout(io.StringIO()) as temp_stdout:
+ config_command.show_config(self.parser.parse_args(['config']))
+ self.assertIn('[core]', temp_stdout.getvalue())
+ self.assertIn('dags_folder = /tmp/test_folder', temp_stdout.getvalue())
Review comment:
This test duplicates/tests the exact same thing as your test in
tests/test_configuration.py -- we don't need to cover the same code twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services